fix(floodsub): remove rand 0.7 dependency#6524
Open
pengqima wants to merge 2 commits into
Open
Conversation
Signed-off-by: pengqima <pengqima@outlook.com>
jxs
reviewed
Jul 21, 2026
| }; | ||
|
|
||
| // Match the approximate maximum entry count of the previous cuckoo filter. | ||
| const RECEIVED_CACHE_CAPACITY: usize = 1 << 20; |
Member
There was a problem hiding this comment.
AFAIR, this doesn't directly map to the cuckoofilter's limit of 2^20 entries, RECEIVED_CACHE_CAPACITY is in items.
A CuckooFilter entry is 1byte on a fixed size 1MiB table, whereas LinkedHashSet is using u64, 8 bytes per entry which at 1 << 20 may be ~32‑48 MiB if full. We should probably reduce this to 1 << 16 which I'd say doesn't make that big of a difference and maintains similar rss
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replace floodsub's cuckoo filter with a bounded cache of 64-bit message hashes.
The new cache preserves the previous approximate limit of 2^20 entries, refreshes the eviction order when a duplicate is observed, and evicts the least recently seen hash when full. This keeps duplicate suppression bounded without retaining complete messages.
Removing
cuckoofilteralso removes its transitive dependency onrand0.7.3, which is flagged by RUSTSEC-2026-0097. There are no public API changes.Fixes #6419.
AI Assistance Disclosure
Tools used (required — write
noneif no AI was used): noneAttestation (required):
Notes & open questions
Change checklist